Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: deploy documentation on releases #629

Merged
merged 6 commits into from
Dec 20, 2019
Merged

ci: deploy documentation on releases #629

merged 6 commits into from
Dec 20, 2019

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 16, 2019 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Add a job in circle ci that deploys docs to the gh-pages branch
  • Docs deploy when a tag matching /^v\d+\.\d+\.\d+$/ regex is pushed

@dyladan dyladan added the document Documentation-related label Dec 16, 2019
@codecov-io
Copy link

codecov-io commented Dec 16, 2019 •
edited
Loading

Codecov Report

Merging #629 into master will decrease coverage by 0.24%.
The diff coverage is 83.57%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   90.49%   90.25%   -0.25%     
==========================================
  Files         181      189       +8     
  Lines        9209     9602     +393     
  Branches      819      876      +57     
==========================================
+ Hits         8334     8666     +332     
- Misses        875      936      +61
Impacted Files Coverage Δ
packages/opentelemetry-core/src/common/types.ts 100% <ø> (ø) ⬆️
...ntelemetry-web/src/enums/PerformanceTimingNames.ts 100% <ø> (ø)
...ckages/opentelemetry-plugin-grpc/test/grpc.test.ts 96.2% <100%> (+0.09%) ⬆️
...telemetry-plugin-document-load/src/documentLoad.ts 97.93% <100%> (-0.2%) ⬇️
packages/opentelemetry-plugin-grpc/src/grpc.ts 96.25% <100%> (+0.1%) ⬆️
...ry-plugin-xml-http-request/src/enums/EventNames.ts 100% <100%> (ø)
...emetry-plugin-xml-http-request/src/enums/Format.ts 100% <100%> (ø)
packages/opentelemetry-web/src/WebTracer.ts 100% <100%> (ø) ⬆️
...lugin-xml-http-request/src/enums/AttributeNames.ts 100% <100%> (ø)
packages/opentelemetry-core/src/utils/wrap.ts 100% <100%> (ø)
... and 25 more

mayurkale22
mayurkale22 approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few maintenance related questions.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@mayurkale22
Copy link
Member

@open-telemetry/javascript-approvers we need more reviews for this one!

mayurkale22
mayurkale22 approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last question: what will be the domain name for gh-pages(documentation) after last change?

@dyladan
Copy link
Member Author

dyladan commented Dec 19, 2019

Last question: what will be the domain name for gh-pages(documentation) after last change?

https://open-telemetry.github.io/opentelemetry-js/

OlivierAlbertini
OlivierAlbertini approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent 🚀🚀

@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Dec 20, 2019
@mayurkale22 mayurkale22 merged commit 3593a69 into open-telemetry:master Dec 20, 2019
@dyladan
Copy link
Member Author

dyladan commented Dec 21, 2019

@mayurkale22 now that this is merged, someone with access to settings has to enable gh-pages. I don't have access.

@dyladan dyladan deleted the ci-docs branch December 21, 2019 16:36
@mayurkale22
Copy link
Member

@mayurkale22 now that this is merged, someone with access to settings has to enable gh-pages. I don't have access.

Even I don't have access to settings tab, maybe @tedsuo can help here.

@dyladan
Copy link
Member Author

dyladan commented Dec 23, 2019

I asked in gitter, but nobody responded

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@obecny
Adding myself to owner (open-telemetry#629)
979d69b 
* chore: sorting packages owners alphabetically

* chore: adding myself for few packages as owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@obecny obecny Awaiting requested review from obecny

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyladan @codecov-io @mayurkale22 @OlivierAlbertini